Skip to content

Vendor libcore 1.49 #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Vendor libcore 1.49 #4060

wants to merge 2 commits into from

Conversation

powerboat9
Copy link
Collaborator

This vendors libcore under libgrust. In the future we can use this for building libcore as a runtime library, and in the near-future we can use it to test progressively later phases of the compiler on libcore as part of the testsuite.

@powerboat9
Copy link
Collaborator Author

Note that this PR leaves usage of libcore to future PRs

CohenArthur
CohenArthur approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I like the idea. I assume this is completely unmodified?

@powerboat9
Copy link
Collaborator Author

Yep. LICENSE-* files are copied from the rustc repo root

P-E-P
P-E-P approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh a bit sad that the Cargo.toml in libcore does not document the library's version. I like @philberty 's idea to track the source of the library, not sure the hash is required but the version should be. And it should be somewhere close so we won't forget to update it. Otherwise LGTM.

@powerboat9 powerboat9 marked this pull request as draft August 13, 2025 15:33
@powerboat9
Copy link
Collaborator Author

powerboat9 commented Sep 1, 2025 •
edited
Loading

Mmh a bit sad that the Cargo.toml in libcore does not document the library's version. I like @philberty 's idea to track the source of the library, not sure the hash is required but the version should be. And it should be somewhere close so we won't forget to update it. Otherwise LGTM.

I've created a file libgrust/version-info

@powerboat9 powerboat9 marked this pull request as ready for review September 1, 2025 18:59
@powerboat9
Add libcore to the list of ignored prefixes
1fde7b0 
contrib/ChangeLog:

	* gcc-changelog/git_commit.py (ignored_prefixes): Add
	'libgrust/rustc-lib/core/'.

Signed-off-by: Owen Avery <[email protected]>
@powerboat9
Import libcore 1.49.0
1fab738 
This commit imports libcore 1.49.0 into a new directory,
"libgrust/rustc-lib/core". LICENSE-* files are taken from the rustc
1.49.0 repository root.

libgrust/ChangeLog:

	* rustc-lib/LICENSE-APACHE: New file.
	* rustc-lib/LICENSE-MIT: New file.
	* rustc-lib/version-info: New file.

Signed-off-by: Owen Avery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powerboat9 @P-E-P @CohenArthur